Expand validators.url to allow FQDNs that have IDNA A-labels #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you also add unit tests for this? |
|
Added unit tests as you requested, let me know if you need any more. Also made a slight change to the IDNA regex to allow for user:pass authentication; all the unit tests passed afterwards so that change should be good to go. |
|
Tests are failing in CI |
|
Hi guys, I would love to use this bugfix. Would it be possible to see what's going wrong with the PR to get this merged? Thanks! |
…RFC1035 limit only applies to label length.
yozachar
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to resolve issue #78. In short, my changes make it so that URLs containing IDNA A-labels (e.g. "http://xn--j1ail.xn--p1ai") will pass validation instead of failing. Please refer to the issue for a more comprehensive explanation of the problem and my proposed solution.